Skip to content

BUG: setitem casting object Index to arrow strings #55639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 21, 2023
Merged

BUG: setitem casting object Index to arrow strings #55639

merged 7 commits into from
Nov 21, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 22, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @jbrockmendel

I think we can treat this as a bug for the new option not a case for deprecation?

I'll open a deprecation PR for all other scenarios after this is in

@mroeschke mroeschke added Indexing Related to indexing on series/frames, not to indexes themselves Strings String extension data type and string data Arrow pyarrow functionality labels Oct 23, 2023
@phofl
Copy link
Member Author

phofl commented Nov 15, 2023

cc @mroeschke

mroeschke
mroeschke reviewed Nov 16, 2023
View reviewed changes
mroeschke
mroeschke reviewed Nov 16, 2023
View reviewed changes
mroeschke
mroeschke reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a merge conflict

@mroeschke mroeschke added this to the 2.2 milestone Nov 18, 2023
mroeschke
mroeschke approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jbrockmendel if any other thoughts

@phofl phofl modified the milestones: 2.2, 2.1.4 Nov 21, 2023
@phofl phofl merged commit 639bd66 into pandas-dev:main Nov 21, 2023
@phofl phofl deleted the setitem_index_inference_string_dtype branch November 21, 2023 20:16
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Nov 21, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 639bd6695940be8737db5c47b71b7ec6c4c88fb7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55639: BUG: setitem casting object Index to arrow strings'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55639-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55639 on branch 2.1.x (BUG: setitem casting object Index to arrow strings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Nov 21, 2023
@phofl
BUG: setitem casting object Index to arrow strings (pandas-dev#55639)
abe636f 
(cherry picked from commit 639bd66)
@phofl phofl mentioned this pull request Nov 21, 2023
Merged
mroeschke pushed a commit that referenced this pull request Nov 21, 2023
@phofl
Backport PR #55639 on branch 2.1.x (BUG: setitem casting object Index…
a8703c0 
… to arrow strings) (#56100)

BUG: setitem casting object Index to arrow strings (#55639)

(cherry picked from commit 639bd66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Indexing Related to indexing on series/frames, not to indexes themselves Strings String extension data type and string data
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke